From 210eefe4ce55e0d468ad07136d43682a4b8e1308 Mon Sep 17 00:00:00 2001 From: Flavio Fois Date: Wed, 18 Mar 2026 10:54:19 +0100 Subject: [PATCH] improve file handling in bug report route to ensure proper closure and error logging --- internal/handlers/bug_report.route.go | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/internal/handlers/bug_report.route.go b/internal/handlers/bug_report.route.go index d0b00d5..3c23acb 100644 --- a/internal/handlers/bug_report.route.go +++ b/internal/handlers/bug_report.route.go @@ -10,6 +10,7 @@ import ( "fmt" "io" "log" + "mime/multipart" "net/http" "strings" "text/template" @@ -92,7 +93,12 @@ func CreateBugReport(db *sqlx.DB) http.HandlerFunc { if err != nil { continue } - defer file.Close() + defer func(file multipart.File) { + err := file.Close() + if err != nil { + log.Fatalf("closing uploaded file failed: %v", err) + } + }(file) data, err := io.ReadAll(file) if err != nil { @@ -272,7 +278,11 @@ func GetBugReportZipById(db *sqlx.DB) http.HandlerFunc { w.Header().Set("Content-Type", "application/zip") w.Header().Set("Content-Disposition", fmt.Sprintf("attachment; filename=\"report-%d.zip\"", report.ID)) - w.Write(buf.Bytes()) + _, err = w.Write(buf.Bytes()) + if err != nil { + return + } + } }